Make ignoring branches work from child directories#13
Merged
sbimochan merged 5 commits intosbimochan:masterfrom Jan 13, 2019
mesaugat:smart-commit-ignore
Merged
Make ignoring branches work from child directories#13sbimochan merged 5 commits intosbimochan:masterfrom mesaugat:smart-commit-ignore
sbimochan merged 5 commits intosbimochan:masterfrom
mesaugat:smart-commit-ignore
Conversation
Owner
|
Respected brother, please review my #12 too. |
sbimochan
reviewed
Jan 13, 2019
| ROOT_DIRECTORY_CMD="git rev-parse --show-toplevel" | ||
| GIT_ROOT_DIRECTORY=$(eval $ROOT_DIRECTORY_CMD) | ||
|
|
||
| CUSTOM_IGNORED_PATH="$GIT_ROOT_DIRECTORY/.smart-commit-ignore" |
Owner
There was a problem hiding this comment.
why is CUSTOM_IGNORED_PATH only declared and not used?
Contributor
Author
There was a problem hiding this comment.
Lol, is it? I think I tested it myself. This might be a blunder. 😞
Owner
There was a problem hiding this comment.
I think your test passed because we have fallback array of branches 😂
sbimochan
approved these changes
Jan 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.ignoreto.smart-commit-ignoreas.ignorecould be anything and doesn't explicitly say what it is ignoring.gitdirectory and find.smart-commit-ignoreif any